Skip to content

TYP: Add ignores for numpy 2.2 updates #61265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 10, 2025
Merged

Conversation

mroeschke
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added Code Style Code style, linting, code_checks Typing type annotations, mypy/pyright type checking labels Apr 10, 2025
@mroeschke mroeschke added this to the 3.0 milestone Apr 10, 2025
@mroeschke mroeschke requested a review from rhshadrach as a code owner April 10, 2025 17:36
@mroeschke mroeschke modified the milestones: 3.0, 2.3 Apr 10, 2025
@mroeschke
Copy link
Member Author

Merging to get CI to green. The type ignore can be addressed in the future

@mroeschke mroeschke merged commit adec21f into pandas-dev:main Apr 10, 2025
42 checks passed
@mroeschke mroeschke deleted the typ/numpy branch April 10, 2025 20:17
Copy link

lumberbot-app bot commented Apr 10, 2025

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 adec21f3fa896684cad04ecf1878a9f2492370ea
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #61265: TYP: Add ignores for numpy 2.2 updates'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-61265-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #61265 on branch 2.3.x (TYP: Add ignores for numpy 2.2 updates)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant