-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: date comparison fails when series is all pd.NaT values #61200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Note also a few builds are failing.
pre-commit.ci autofix |
@rhshadrach I just incorporated the changes! Please let me know if everything looks okay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Co-authored-by: Richard Shadrach <[email protected]>
Co-authored-by: Richard Shadrach <[email protected]>
Co-authored-by: Richard Shadrach <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Good to hear! Thank you for guidance :) |
Looks like this PR re-added the 1.3MB Pandas Cookbook jpeg into main. Looks like we should hard revert this commit? cc @datapythonista |
I'm travelling and I may not be able to do it for several hours or tomorrow. Do you have permissions to access the project settings and enable the force push option? If you can do that, it's aa easy as clone, git reset --soft head~ and git push -f. If you don't have access, I can see if I can give you permissons, but I don't think I can. Otherwise let's try npt to merge until then, which will make things significantly more complicated. |
@pandas-dev/pandas-core I hard reverted this, as it reintroduced the big image we wanted to avoid having in our history. @Mohit-Kundu sorry about this. We had to rewrite pandas git history, which likely caused that unrelated image ending up in your PR. Sorry we didn't see you before merging, but now we had to hard undo the resulting commit of this PR to avoid having that image in our history and increasing even more the repository size (it's 433Mb even being extra careful of not adding big files). Given this, can I ask you to please open this PR again with the same changes, but without the image? Thank you! @mroeschke I see you have the same permissions as me already. I can't add people, but all good for now I think. |
Thanks @mroeschke @datapythonista |
@datapythonista I'd be happy to do that! However, I'm not exactly sure how to reopen the PR, since on my end it shows that the pull request has been successfully merged and closed. I'd really appreciate your guidance on the best way to proceed; should I open a new PR with the same changes but without the image, or is there another approach you would recommend? Thanks! |
Yes, I think this is the best. Thank you! |
doc/source/whatsnew/v3.0.0.rst
file if fixing a bug or adding a new feature.