Skip to content

TST: add tests for old version of numexpr #6109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 26, 2014
Merged

TST: add tests for old version of numexpr #6109

merged 3 commits into from
Jan 26, 2014

Conversation

cpcloud
Copy link
Member

@cpcloud cpcloud commented Jan 26, 2014

closes #5857
closes #5855
closes #5845

@jreback
Copy link
Contributor

jreback commented Jan 26, 2014

think you need to add numexpr < 2.0 to py2.6 build?

@cpcloud
Copy link
Member Author

cpcloud commented Jan 26, 2014

yep i didn't forget ... i'm doing it now :)

@ghost ghost assigned cpcloud Jan 26, 2014
@jreback
Copy link
Contributor

jreback commented Jan 26, 2014

look ok to me

@cpcloud
Copy link
Member Author

cpcloud commented Jan 26, 2014

cool i just want to move skip_if_no_ne to testing ... DRY and all ... and it'll give a more informative msg on skip

@jreback
Copy link
Contributor

jreback commented Jan 26, 2014

cool

@cpcloud
Copy link
Member Author

cpcloud commented Jan 26, 2014

hm getting a timeout from the redhat server ... rehashed ... let me see if that passes

@cpcloud
Copy link
Member Author

cpcloud commented Jan 26, 2014

nvm

@cpcloud
Copy link
Member Author

cpcloud commented Jan 26, 2014

@jreback stepping out for a bit can u merge if green? thx

@jreback
Copy link
Contributor

jreback commented Jan 26, 2014

sure

@cpcloud
Copy link
Member Author

cpcloud commented Jan 26, 2014

Ok I'll merge. @jreback any last words?

@jreback
Copy link
Contributor

jreback commented Jan 26, 2014

sorry stepped out too

bombS away

cpcloud added a commit that referenced this pull request Jan 26, 2014
TST: add tests for old version of numexpr
@cpcloud cpcloud merged commit 5f404d9 into pandas-dev:master Jan 26, 2014
@cpcloud
Copy link
Member Author

cpcloud commented Jan 26, 2014

Crap I just undid @y-p's nosetests v pr I'm on my phone right now can't get to it ... Can do it later tonight or if someone wants to fix thats cool too

@ghost
Copy link

ghost commented Jan 26, 2014

I'll fix it.

@cpcloud
Copy link
Member Author

cpcloud commented Jan 26, 2014

Thanks. Sorry about that. Don't mean to create moar werk :/

@ghost
Copy link

ghost commented Jan 26, 2014

we all clobber at one point or another. np.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants