Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: Improve ImportError message to suggest importing dependencies directly for full error details #61084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Improve ImportError message to suggest importing dependencies directly for full error details #61084
Changes from 5 commits
41c3481
a46dc65
0267293
d65a970
51826c0
2fa208d
734a707
4efb33a
17dae60
5f5ab6a
05a5fb8
7199ee6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we monkeypatch
_hard_dependencies
with a fake module and test that instead? I'm worried about this test having side effects by modifyingsys.modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, modifying
sys.modules
directly is not an ideal approach.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved in 5f5ab6a. Instead of monkeypatching
_hard_dependencies
, I mockedbuiltins.__import__
to raise anImportError
when a specific dependency is imported. This approach was chosen because reloading pandas withimportlib.reload()
resets the module, which would override any monkeypatch applied to_hard_dependencies
.If there's a better approach, I'm happy to consider it.