Skip to content

Backport PR #61042: CI/TST: Fix xfail in test_columns_dtypes_not_invalid for pyarrow nightly #61044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Backport PR #61042: CI/TST: Fix xfail in test_columns_dtypes_not_invalid for pyarrow nightly #61044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
059a327
Backport PR #61042: CI/TST: Fix xfail in test_columns_dtypes_not_inva…
mroeschke Mar 3, 2025
dd1676f
remove xfail
mroeschke Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pandas/compat/pyarrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
pa_version_under17p0 = _palv < Version("17.0.0")
pa_version_under18p0 = _palv < Version("18.0.0")
pa_version_under19p0 = _palv < Version("19.0.0")
pa_version_under20p0 = _palv < Version("20.0.0")
HAS_PYARROW = True
except ImportError:
pa_version_under10p1 = True
Expand All @@ -32,4 +33,5 @@
pa_version_under17p0 = True
pa_version_under18p0 = True
pa_version_under19p0 = True
pa_version_under20p0 = True
HAS_PYARROW = False
37 changes: 21 additions & 16 deletions pandas/tests/io/test_parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
pa_version_under13p0,
pa_version_under15p0,
pa_version_under19p0,
pa_version_under20p0,
)

import pandas as pd
Expand Down Expand Up @@ -1103,24 +1104,28 @@ def test_read_dtype_backend_pyarrow_config_index(self, pa):
expected=expected,
)

def test_columns_dtypes_not_invalid(self, pa):
@pytest.mark.parametrize(
"columns",
[
[0, 1],
pytest.param(
[b"foo", b"bar"],
marks=pytest.mark.xfail(
pa_version_under20p0,
raises=NotImplementedError,
reason="https://github.com/apache/arrow/pull/44171",
),
),
[
datetime.datetime(2011, 1, 1, 0, 0),
datetime.datetime(2011, 1, 1, 1, 1),
],
],
)
def test_columns_dtypes_not_invalid(self, pa, columns):
df = pd.DataFrame({"string": list("abc"), "int": list(range(1, 4))})

# numeric
df.columns = [0, 1]
check_round_trip(df, pa)

# bytes
df.columns = [b"foo", b"bar"]
with pytest.raises(NotImplementedError, match="|S3"):
# Bytes fails on read_parquet
check_round_trip(df, pa)

# python object
df.columns = [
datetime.datetime(2011, 1, 1, 0, 0),
datetime.datetime(2011, 1, 1, 1, 1),
]
df.columns = columns
check_round_trip(df, pa)

def test_empty_columns(self, pa):
Expand Down
Loading