-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: Ensure to_datetime raises errors for out-of-bounds scalar inputs #60744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
510951b
ENH: Add test for to_datetime with scalar out of bounds value
kosiew 16d14ab
ENH: Fix out-of-bounds error handling in _to_datetime_with_unit
kosiew 4a2ad59
ENH: Add debugging breakpoint in _to_datetime_with_unit for troublesh…
kosiew cb710ee
ENH: Improve error handling for out-of-bounds uint64 values in _to_da…
kosiew b9b2d7a
Add test for lower bound
kosiew 4924a6d
ENH: Change return type of _to_datetime_with_unit to Index
kosiew 14562ce
ENH: Add type check for DatetimeIndex in _to_datetime_with_unit
kosiew a3593ed
Merge branch 'main' into fix-datetime
kosiew a4ffcd3
Added entry in v3.0.0.rst
kosiew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making the annotation -> DatetimeIndex reflects that reality more precisely and helps both developers and tooling (like mypy) be certain of the return type.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If
errors=="ignore"
we would get anIndex[object]
back so this is correctThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. Thanks for pointing this out.