Skip to content

TST: Fix test_eval.py #6074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2014
Merged

TST: Fix test_eval.py #6074

merged 1 commit into from
Jan 25, 2014

Conversation

dsm054
Copy link
Contributor

@dsm054 dsm054 commented Jan 24, 2014

Fixes typos found in #GH 6069. Does not change the tests to ensure those branches are exercised.

@cpcloud
Copy link
Member

cpcloud commented Jan 24, 2014

Looks like u have an extra commit in there

@dsm054
Copy link
Contributor Author

dsm054 commented Jan 24, 2014

Urf. You're right. If I squash 'em, is there a way to associate the new PR with this one or should I close and open a new one?

@cpcloud
Copy link
Member

cpcloud commented Jan 24, 2014

No no don't do that. Hold on a sec I'll show u how to just get that commit out

@cpcloud
Copy link
Member

cpcloud commented Jan 24, 2014

Just peel it off like so:

git reset HEAD~1
git stash
git reset --hard upstream/master
git stash pop
git add .
git commit -m'TST: fix test_eval typos'

@cpcloud
Copy link
Member

cpcloud commented Jan 24, 2014

alternatively you could probably cherry pick the commit into a new branch, reset hard on upstream/master and then merge the branch u just created back into the one u just reset

@cpcloud
Copy link
Member

cpcloud commented Jan 24, 2014

something like this

(say you're on a branch called orig_branch)

git checkout -b tmp
git cherry-pick 42e3a76
git checkout orig_branch
git reset --hard upstream/master
git merge tmp
git branch -D tmp
git push --force

@cpcloud
Copy link
Member

cpcloud commented Jan 24, 2014

Or if you want I can merge this :)

@dsm054
Copy link
Contributor Author

dsm054 commented Jan 24, 2014

Hmm. I followed the cherry-pick instructions, but I'm not sure what the effect was; that branch still seems to show two commits, and the result of git push --force was eacc354..1020b51 master -> master with no reference to the fix-test_eval branch.

@cpcloud
Copy link
Member

cpcloud commented Jan 25, 2014

now that i think about it i don't think it makes sense to cherry pick here ... the first instructions are what i use when i do this ... you can just mutate the branch rather than having to make a new one

@cpcloud
Copy link
Member

cpcloud commented Jan 25, 2014

bam!

@dsm054
Copy link
Contributor Author

dsm054 commented Jan 25, 2014

Thanks for the assistance! I'm afraid my brain is pre-git, and I can't afford the upgrade.

@cpcloud
Copy link
Member

cpcloud commented Jan 25, 2014

:) It's okay, my git chops are getting rusty hope cherry picking wasn't cherry bombing instead

cpcloud added a commit that referenced this pull request Jan 25, 2014
@cpcloud cpcloud merged commit 8a02e68 into pandas-dev:master Jan 25, 2014
@cpcloud
Copy link
Member

cpcloud commented Jan 25, 2014

Thx

@dsm054 dsm054 deleted the fix-test_eval branch January 25, 2014 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants