Skip to content

TST(string dtype): Resolve to_latex xfail #60614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach commented Dec 29, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

map_index expects a return of None in certain cases. When using the string dtype, this gets stored in the resulting DataFrame as NaN which is truthy. Adding the explicit NA check resolves.

@rhshadrach rhshadrach added Strings String extension data type and string data IO LaTeX to_latex labels Dec 29, 2024
@rhshadrach rhshadrach added this to the 2.3 milestone Dec 29, 2024
@rhshadrach rhshadrach requested a review from attack68 as a code owner December 29, 2024 13:49
@rhshadrach rhshadrach changed the title TST(string dtype): Fix to_latex xfail TST(string dtype): Resolve to_latex xfail Dec 29, 2024
Copy link
Contributor

@attack68 attack68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mroeschke mroeschke merged commit 82f4354 into pandas-dev:main Dec 29, 2024
55 checks passed
@mroeschke
Copy link
Member

Thanks @rhshadrach

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Dec 29, 2024
mroeschke pushed a commit that referenced this pull request Dec 29, 2024
…ex xfail) (#60617)

Backport PR #60614: TST(string dtype): Resolve to_latex xfail

Co-authored-by: Richard Shadrach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO LaTeX to_latex Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants