-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
ENH: removed median percentile to be always included in describe GH #60550 #60557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 9 commits
05709ef
5c745f3
7264ee6
2552f9a
3e08684
c1c1879
dd875da
98a0143
aee5795
5cf9a70
258cfc6
bfbffd0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10795,7 +10795,8 @@ def describe( | |
The percentiles to include in the output. All should | ||
fall between 0 and 1. The default is | ||
``[.25, .5, .75]``, which returns the 25th, 50th, and | ||
75th percentiles. | ||
75th percentiles. If a blank list is passed, then returns | ||
only the 50th percentile value. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I do not think this should be the behavior. If I pass an empty list, I should not get any percentiles. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was trying to preserve the default percentile behavior. I will change this so that percentiles are omitted if a blank list is passed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we should remove the 50th percentile without at least a deprecation warning. Reporting the median by default is incredibly helpful (by default) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Agreed we should not be changing the default behavior. Recommend setting There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Okay, so we will add an argument There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @rhshadrach I got confused. the default for percentiles is already @ZenithClown I believe what @rhshadrach means is to change the behavior so that the 50th percentile is removed if a user explicitly passes in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @asishm - me too! Agreed leaving the default as |
||
include : 'all', list-like of dtypes or None (default), optional | ||
A white list of data types to include in the result. Ignored | ||
for ``Series``. Here are the options: | ||
|
Uh oh!
There was an error while loading. Please reload this page.