-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Make -NaN and -nan default NA values #6038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Probably |
@Bklyn yep on |
Sorry for the noob-ishness, but what is the suggested way to run the tests against not-yet-installed version of pandas (e.g. from my working copy)? I'm getting import errors if I run the test script by hand unless I "setup.py install" first. At any rate, the tests do not fail if I don't change them, presumably because they're not trying the new -nan values. Will fix the code and update the PR with the tests for completeness. |
@Bklyn make this part of the same test (which SHOULD fail if the _NA_VALUES are not updated) e.g.
This way the test have to be updated as well |
then
|
Is there anything left for me to do on this PR? |
pls add a release notes entry (put in 0.13.1 API), rebase and squash to 1 commit: https://github.com/pydata/pandas/wiki/Using-Git |
@@ -104,6 +104,10 @@ Enhancements | |||
result | |||
result.loc[:,:,'ItemA'] | |||
|
|||
- Add ``-NaN`` and ``-nan`` to the default set of NA values (:issue:`5952`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update this too (actually add to the text): http://pandas.pydata.org/pandas-docs/dev/io.html#na-values
OK, I think thats got it. |
@@ -18,6 +18,9 @@ There are several new or updated docs sections including: | |||
API changes | |||
~~~~~~~~~~~ | |||
|
|||
- Add ``-NaN`` and ``-nan`` to the default set of NA values (:issue:`5952`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just add this line also to doc/source/release.rst
under API changes as well. we use the whatsnew to 'announce' important changes, and the release.rst as a log of them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be there now.
fine by me. |
Make -NaN and -nan default NA values
thanks @Bklyn nice little PR, and you were very responsive!! |
Thanks for the hand-holding and the feedback. You guys (and perhaps gals?) do a great job with pandas and your attention to code and documentation quality is impressive. |
welcome! feel free to tackle any open issues! |
Yeah, we need a gal commiter. Well, a ninja that happens to be a gal. |
closes #5952