Skip to content

TST (string dtype): resolve xfails for frame methods #60336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

TST (string dtype): resolve xfails for frame methods #60336

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e559a1b
TST (string dtype): resolve xfails for frame methods
WillAyd Nov 16, 2024
ee46751
feedback
WillAyd Dec 13, 2024
40db2ea
Fixed test failures
WillAyd Dec 23, 2024
638cb77
Merge remote-tracking branch 'upstream/main' into fix-string-frame-me…
jorisvandenbossche Jan 2, 2025
d3dc930
remove interpolate changes
jorisvandenbossche Jan 2, 2025
40db552
Merge branch 'main' into fix-string-frame-methods
WillAyd Jan 22, 2025
572d62c
Remove using_infer_string from astype("string")
WillAyd Jan 22, 2025
b8beead
Use string_dtype_no_object fixture
WillAyd Jan 22, 2025
28ce5f0
Xfail test with empty index
WillAyd Jan 22, 2025
d2d1774
Revert test_to_dict_of_blocks
WillAyd Jan 22, 2025
2ce3d3d
Merge branch 'main' into fix-string-frame-methods
WillAyd Feb 3, 2025
4407e0b
Merge branch 'main' into fix-string-frame-methods
WillAyd Feb 21, 2025
20f6b26
Remove empty column related test fixes
WillAyd Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions pandas/tests/frame/methods/test_astype.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
import numpy as np
import pytest

from pandas._config import using_string_dtype

import pandas.util._test_decorators as td

import pandas as pd
Expand Down Expand Up @@ -745,9 +743,11 @@ def test_astype_tz_object_conversion(self, tz):
result = result.astype({"tz": "datetime64[ns, Europe/London]"})
tm.assert_frame_equal(result, expected)

@pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string) GH#60639")
def test_astype_dt64_to_string(
self, frame_or_series, tz_naive_fixture, using_infer_string
self,
frame_or_series,
tz_naive_fixture,
string_dtype_no_object,
):
# GH#41409
tz = tz_naive_fixture
Expand All @@ -757,23 +757,17 @@ def test_astype_dt64_to_string(
dta[0] = NaT

obj = frame_or_series(dta)
result = obj.astype("string")
result = obj.astype(string_dtype_no_object)

# Check that Series/DataFrame.astype matches DatetimeArray.astype
expected = frame_or_series(dta.astype("string"))
expected = frame_or_series(dta.astype(string_dtype_no_object))
tm.assert_equal(result, expected)

item = result.iloc[0]
if frame_or_series is DataFrame:
item = item.iloc[0]
if using_infer_string:
assert item is np.nan
else:
assert item is pd.NA

# For non-NA values, we should match what we get for non-EA str
alt = obj.astype(str)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe repeat the above also with dta.astype("str"), so we test the default string dtype as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to leave a comment on this. It's not visible in the diff but there is already a tm.assert_frame_equal call a few lines up from this. Is there any expected value calling that and then calling it with a slice?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to repeat the expected = frame_or_series(dta.astype("string")) as expected = frame_or_series(dta.astype("str")) (to test both the NA and NaN variant)

assert np.all(alt.iloc[1:] == result.iloc[1:])
assert item is string_dtype_no_object.na_value

def test_astype_td64_to_string(self, frame_or_series):
# GH#41409
Expand Down