Skip to content

ENH: set __module__ on date_range and bdate_range #60264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

chanshing
Copy link
Contributor

@chanshing chanshing commented Nov 9, 2024

This decorates date_range and bdate_range with @set_module('pandas') (similar to #55171)

@chanshing chanshing changed the title Decorate date range set module Decorate date_range with @set_module('pandas') Nov 9, 2024
@chanshing chanshing force-pushed the decorate-date-range-set-module branch from cc6271c to 9d05b68 Compare November 9, 2024 16:06
@chanshing chanshing changed the title Decorate date_range with @set_module('pandas') Decorate date_range and bdate_range with @set_module('pandas') Nov 9, 2024
@simonjayhawkins simonjayhawkins added Output-Formatting __repr__ of pandas objects, to_string Sprints Sprint Pull Requests labels Nov 9, 2024
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chanshing

@simonjayhawkins simonjayhawkins added this to the 3.0 milestone Nov 9, 2024
@jorisvandenbossche jorisvandenbossche changed the title Decorate date_range and bdate_range with @set_module('pandas') ENH; set __module__ on date_range and bdate_range Nov 11, 2024
@jorisvandenbossche jorisvandenbossche changed the title ENH; set __module__ on date_range and bdate_range ENH: set __module__ on date_range and bdate_range Nov 11, 2024
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

Because of merging some of the related PRs, there is now a merge conflict in the tests file. Could you merge the latest main to resolve that conflict? (and let us know if you need any help with that)

@simonjayhawkins simonjayhawkins merged commit ce2570f into pandas-dev:main Nov 11, 2024
49 of 51 checks passed
@chanshing chanshing deleted the decorate-date-range-set-module branch November 11, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Output-Formatting __repr__ of pandas objects, to_string Sprints Sprint Pull Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants