Skip to content

ENH: set __module__ on Series #60263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2024
Merged

ENH: set __module__ on Series #60263

merged 2 commits into from
Nov 11, 2024

Conversation

dl-lim
Copy link
Contributor

@dl-lim dl-lim commented Nov 9, 2024 •
edited by simonjayhawkins
Loading

#55178

@simonjayhawkins simonjayhawkins mentioned this pull request Nov 9, 2024
Closed
5 tasks
@simonjayhawkins simonjayhawkins added Output-Formatting __repr__ of pandas objects, to_string Sprints Sprint Pull Requests labels Nov 9, 2024
@dl-lim dl-lim changed the title ENH: set __module__ with set_module decorator on Series ENH: set __module__ with set_module decorator on Series Nov 9, 2024
@dl-lim dl-lim marked this pull request as ready for review November 9, 2024 17:38
@dl-lim dl-lim requested a review from noatamir as a code owner November 9, 2024 17:38
@simonjayhawkins simonjayhawkins added this to the 3.0 milestone Nov 9, 2024
simonjayhawkins
simonjayhawkins approved these changes Nov 9, 2024
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dl-lim

cc @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche changed the title ENH: set __module__ with set_module decorator on Series ENH: set __module__ on Series Nov 11, 2024
jorisvandenbossche
jorisvandenbossche approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@jorisvandenbossche jorisvandenbossche merged commit b434476 into pandas-dev:main Nov 11, 2024
51 checks passed
@jorisvandenbossche jorisvandenbossche mentioned this pull request Nov 11, 2024
Open
11 tasks
@lesteve lesteve mentioned this pull request Nov 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

@noatamir noatamir Awaiting requested review from noatamir noatamir is a code owner

Assignees
No one assigned
Labels
Output-Formatting __repr__ of pandas objects, to_string Sprints Sprint Pull Requests
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dl-lim @jorisvandenbossche @simonjayhawkins