-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: Set __module__ on StringDtype #60261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jorisvandenbossche
merged 11 commits into
pandas-dev:main
from
espoirMur:man-group/set-module-stringdtype
Nov 11, 2024
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ab2817c
fix the string datatype
espoirMur 7e4e60a
remove .env
espoirMur b1986fc
fix the import error
espoirMur 374fed8
fix failed test
espoirMur be69547
Update string_.py
espoirMur 9e125e3
apply ruff
espoirMur 44155ac
remove the module on basestring
espoirMur 1f2fb54
Update string_.py
espoirMur 9dba8f2
fix stuff
espoirMur 996db1f
Update string_.py
espoirMur 2c032bd
Merge branch 'main' into man-group/set-module-stringdtype
jorisvandenbossche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,7 +28,10 @@ | |
pa_version_under10p1, | ||
) | ||
from pandas.compat.numpy import function as nv | ||
from pandas.util._decorators import doc | ||
from pandas.util._decorators import ( | ||
doc, | ||
set_module, | ||
) | ||
from pandas.util._exceptions import find_stack_level | ||
|
||
from pandas.core.dtypes.base import ( | ||
|
@@ -86,6 +89,7 @@ | |
from pandas import Series | ||
|
||
|
||
@set_module("pandas") | ||
@register_extension_dtype | ||
class StringDtype(StorageExtensionDtype): | ||
""" | ||
|
@@ -374,6 +378,7 @@ def __from_arrow__( | |
return new_string_array | ||
|
||
|
||
@set_module("pandas") | ||
class BaseStringArray(ExtensionArray): | ||
""" | ||
Mixin class for StringArray, ArrowStringArray. | ||
|
@@ -532,6 +537,8 @@ def _str_map_nan_semantics( | |
|
||
# error: Definition of "_concat_same_type" in base class "NDArrayBacked" is | ||
# incompatible with definition in base class "ExtensionArray" | ||
|
||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please revert these additions |
||
class StringArray(BaseStringArray, NumpyExtensionArray): # type: ignore[misc] | ||
""" | ||
Extension array for string data. | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AttributeError: module 'pandas' has no attribute 'BaseStringArray'