Update mypy version from 1.11.2 to 1.13.0 #60260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjayhawkins
added
Typing
|
Man Group London Hackathon 2024 |
Removed type ignores
Fix typing error casting `._values` to a `DataFrame` in `pandas.core.generic`
Removed a missed type ignore
`nanops.nanmedian` typing fix
Fix indexing typing error
New err mypy
Fix column typeerror
type ignore common.py
fix line too long
Fixed type:ignore from type-arg to type-var
Call overload err
| @@ -738,7 +740,7 @@ def nanmedian(values, *, axis: AxisInt | None = None, skipna: bool = True, mask= | |||
|
|
|||
| Returns | |||
| ------- | |||
| result : float | |||
| result : float | ndarray | |||
There was a problem hiding this comment.
can you comment in PR a example returning an array
There was a problem hiding this comment.
Sure, the following code would be an example of when the function would return an array, and not a float:
import pandas as pd
import numpy as np
pd.core.nanops.nanmedian(
np.array([
[1, 2, 3],
[2, 3, 4]
],
axis=1)
)This code would output,
array([2., 3.])Correct typing fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.