TST: Add test for visibility of x label and xtick labels for plot.hexbin
#60253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonmokk
force-pushed
the
test-hexbin-plot-xlabels
branch
4 times, most recently
from
747d5da to
691f59e
Compare
rhshadrach
added
Visualization
mroeschke
reviewed
Nov 12, 2024
| @@ -2589,6 +2589,14 @@ def test_plot_period_index_makes_no_right_shift(self, freq): | |||
| result = ax.get_lines()[0].get_xdata() | |||
| assert all(str(result[i]) == str(expected[i]) for i in range(4)) | |||
|
|
|||
| def test_plot_display_xlabel_and_xticks(self): | |||
| # GH#44050 | |||
| df = DataFrame(np.random.default_rng(2).random((1000, 2)), columns=["a", "b"]) | |||
There was a problem hiding this comment.
Suggested change
| df = DataFrame(np.random.default_rng(2).random((1000, 2)), columns=["a", "b"]) | |
| df = DataFrame(np.random.default_rng(2).random((10, 2)), columns=["a", "b"]) |
If the test is not dependent on the size of the data, best to keep it minimal
There was a problem hiding this comment.
Ah makes sense, I've updated it.
TST: Add test for visibility of x label and xtick labels for plot.hexbin TST: Add test for visibility of x label and xtick labels for plot.hexbin TST: Add test for visibility of x label and xtick labels for plot.hexbin TST: Add test for visibility of x label and xtick labels for plot.hexbin Minimize size of test data
jasonmokk
force-pushed
the
test-hexbin-plot-xlabels
branch
from
691f59e to
a894b64
Compare
mroeschke
approved these changes
Nov 12, 2024
|
Thanks @jasonmokk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a unit test to
pandas/tests/plotting/frame/test_frame.pyto verify that hexbin plots correctly display x labels and xtick labels. Adds a test for the solved issue described in GH #44050.