Skip to content

DOC: fix SA01,ES01 for pandas.core.groupby.DataFrameGroupBy.groups, pandas.core.groupby.SeriesGroupBy.groups and pandas.core.resample.Resampler.groups #60252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 11, 2024
Merged

DOC: fix SA01,ES01 for pandas.core.groupby.DataFrameGroupBy.groups, pandas.core.groupby.SeriesGroupBy.groups and pandas.core.resample.Resampler.groups #60252

merged 4 commits into from
Nov 11, 2024

Conversation

tuhinsharma121
Copy link
Contributor

fixes

pandas.core.groupby.DataFrameGroupBy.groups SA01,ES01

@tuhinsharma121 tuhinsharma121 marked this pull request as ready for review November 8, 2024 19:08
rhshadrach
rhshadrach requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@tuhinsharma121 tuhinsharma121 marked this pull request as draft November 10, 2024 17:53
@tuhinsharma121 tuhinsharma121 changed the title DOC: fix SA01,ES01 for pandas.core.groupby.DataFrameGroupBy.groups DOC: fix SA01,ES01 for pandas.core.groupby.DataFrameGroupBy.groups, pandas.core.groupby.SeriesGroupBy.groups and pandas.core.resample.Resampler.groups Nov 10, 2024
@tuhinsharma121 tuhinsharma121 marked this pull request as ready for review November 10, 2024 18:14
@mroeschke mroeschke requested a review from rhshadrach November 11, 2024 19:44
rhshadrach
rhshadrach approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added this to the 3.0 milestone Nov 11, 2024
@rhshadrach rhshadrach merged commit f9f72d1 into pandas-dev:main Nov 11, 2024
56 of 57 checks passed
@rhshadrach
Copy link
Member

Thanks @tuhinsharma121!

@tuhinsharma121 tuhinsharma121 deleted the pandas.core.groupby.DataFrameGroupBy.groups branch November 12, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner

Assignees
No one assigned
Labels
Docs Groupby
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tuhinsharma121 @rhshadrach