BUG: Creation of UInt64 column with 18446744073709551615 throws RuntimeWarning #60214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
requested changes
Nov 6, 2024
rhshadrach
requested changes
Nov 11, 2024
| data.soften_mask() # set hardmask False if it was True | ||
| data[mask] = fill_value | ||
| dtype = cast(np.dtype, data.dtype) | ||
| if isinstance(dtype, ExtensionDtype) and dtype.name.startswith("Masked"): |
There was a problem hiding this comment.
I haven't checked thoroughly, but I think you want dtype._can_hold_na instead of having logic depend on the name of the dtype.
| ), | ||
| ], | ||
| ) | ||
| def test_sanitize_masked_array_with_masked_ea(values, dtype, expected): |
There was a problem hiding this comment.
Can you add a case that tests for a large number as in an issue.
Also start the test with a reference to the GitHub issue:
# GH#60050
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
18446744073709551615throws RuntimeWarning #60050