BUG: fix inspect usage when pyarrow or jinja2 is not installed #60196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
approved these changes
Nov 5, 2024
|
Thanks @jorisvandenbossche |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Nov 5, 2024
…jinja2 is not installed
jorisvandenbossche
added a commit
that referenced
this pull request
Nov 5, 2024
…ow or jinja2 is not installed) (#60201) Backport PR #60196: BUG: fix inspect usage when pyarrow or jinja2 is not installed Co-authored-by: Joris Van den Bossche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started with trying to fix the xfail when using the string dtype without pyarrow installed, but in practice this was not related to the string dtype, but just to pyarrow not being available (and apparently we only test that case in the build with the future string dtype enabled?).
We need to ensure to return an AttributeError instead of ImportError when accessing attributes on Series/DataFrame, and then
inspect.getmemberswill ignore that error.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.