Skip to content

TST (string dtype): add explicit object vs str dtype to index fixture #60116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jorisvandenbossche
Copy link
Member

Also for when we switch the default, that we keep testing object dtype

@jorisvandenbossche jorisvandenbossche added Testing pandas testing functions or related to the test suite Strings String extension data type and string data labels Oct 28, 2024
@jorisvandenbossche jorisvandenbossche added this to the 2.3 milestone Oct 28, 2024
@jorisvandenbossche
Copy link
Member Author

The two failing builds are failing on main as well, so going to merge this (blocking a follow-up PR)

@jorisvandenbossche jorisvandenbossche merged commit 7bd594c into pandas-dev:main Oct 30, 2024
49 of 51 checks passed
@jorisvandenbossche jorisvandenbossche deleted the string-dtype-tests-indexes branch October 30, 2024 09:29
Copy link

lumberbot-app bot commented Oct 30, 2024

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.3.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 7bd594c81acb5f6428e9ef54ba5a9da1f2860a89
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #60116: TST (string dtype): add explicit object vs str dtype to index fixture'
  1. Push to a named branch:
git push YOURFORK 2.3.x:auto-backport-of-pr-60116-on-2.3.x
  1. Create a PR against branch 2.3.x, I would have named this PR:

"Backport PR #60116 on branch 2.3.x (TST (string dtype): add explicit object vs str dtype to index fixture)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@jorisvandenbossche
Copy link
Member Author

Manual backport at #60136

jorisvandenbossche added a commit that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Strings String extension data type and string data Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant