-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: read_csv
with chained fsspec TAR file and compression="infer"
#60100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
795b260
0f0ac4e
f05dec5
cb94060
9e1ba27
3aaad97
778e385
33b601d
fc469c7
deb21df
32fef29
0fe1864
0dc0444
04f9246
53d997f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,6 +25,7 @@ | |
WASM, | ||
is_platform_windows, | ||
) | ||
import pandas.util._test_decorators as td | ||
|
||
import pandas as pd | ||
import pandas._testing as tm | ||
|
@@ -642,6 +643,16 @@ def close(self): | |
handles.created_handles.append(TestError()) | ||
|
||
|
||
@td.skip_if_no("fsspec") | ||
def test_read_csv_chained_url_no_error(): | ||
tar_file = "pandas/tests/io/data/tar/test-csv.tar" | ||
try: | ||
pd.read_csv(f"tar://test.csv::file://{tar_file}", compression=None) | ||
pd.read_csv(f"tar://test.csv::file://{tar_file}", compression="infer") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you check the results are as expected. |
||
except Exception as e: | ||
pytest.fail(e) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the benefit of using pytest.fail as opposed to just removing the try-except entirely? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was initially thinking that I need to use somekind of pytest function to validate. But it seems like it wouldn't be the case for this |
||
|
||
|
||
@pytest.mark.parametrize( | ||
"reader", | ||
[ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment with the issue number as the first line