STY: Bump pyright, pyupgrade and mypy for new PEP-696 syntax #60006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Code Style
rhshadrach
reviewed
Oct 10, 2024
| @@ -369,7 +369,7 @@ def _coerce_to_array( | |||
| assert dtype == "boolean" | |||
| return coerce_to_array(value, copy=copy) | |||
|
|
|||
| def _logical_method(self, other, op): | |||
| def _logical_method(self, other, op): # type: ignore[override] | |||
There was a problem hiding this comment.
I've never seen a type-ignore on the signature of a function, do you know why this is needed?
There was a problem hiding this comment.
Here's the mypy error
pandas/core/arrays/boolean.py:372: error: Signature of "_logical_method" incompatible with supertype "BaseMaskedArray" [override]
pandas/core/arrays/boolean.py:372: note: Superclass:
pandas/core/arrays/boolean.py:372: note: def _arith_method(self: BaseMaskedArray, other: Any, op: Any) -> Any
pandas/core/arrays/boolean.py:372: note: Subclass:
pandas/core/arrays/boolean.py:372: note: def _logical_method(self, other: Any, op: Any) -> Any
pandas/core/arrays/boolean.py:372: note: Superclass:
pandas/core/arrays/boolean.py:372: note: def _arith_method(self: BaseMaskedArray, other: Any, op: Any) -> Any
pandas/core/arrays/boolean.py:372: note: Subclass:
pandas/core/arrays/boolean.py:372: note: def _logical_method(self, other: Any, op: Any) -> AnyIn BasedMaskedArray we assign _logical_method = _arith_method, but override _logical_method in BooleanArray. It looks mypy is doing some inference on self even though we don't type it?
There was a problem hiding this comment.
I think self is typed implicitly, yes. Makes sense that it's an override issue, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also bumps flake8 and pre-commit which should have innocuous changes