Skip to content

BUG: fix to_numeric raises TypeError for Timedelta and Timestamp scalar #59974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 5, 2024
Merged

BUG: fix to_numeric raises TypeError for Timedelta and Timestamp scalar #59974

merged 2 commits into from
Oct 5, 2024

Conversation

yuanx749
Copy link
Contributor

@yuanx749 yuanx749 commented Oct 5, 2024 •
edited
Loading

@rhshadrach rhshadrach added Bug Timedelta Timedelta data type Timestamp pd.Timestamp and associated methods labels Oct 5, 2024
@rhshadrach rhshadrach added this to the 3.0 milestone Oct 5, 2024
@rhshadrach rhshadrach added the Dtype Conversions Unexpected or buggy dtype conversions label Oct 5, 2024
rhshadrach
rhshadrach approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; wouldn't mind another eye on it. cc @mroeschke

@mroeschke mroeschke merged commit e740857 into pandas-dev:main Oct 5, 2024
51 checks passed
@mroeschke
Copy link
Member

Thanks @yuanx749

@yuanx749 yuanx749 deleted the numeric-td branch October 6, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Bug Dtype Conversions Unexpected or buggy dtype conversions Timedelta Timedelta data type Timestamp pd.Timestamp and associated methods
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

BUG: pd.to_numeric(timedelta_scalar) raises TypeError
3 participants
@yuanx749 @mroeschke @rhshadrach