timedelta on datetime df, series arithmetic #59844
Conversation
| @@ -997,6 +997,8 @@ def _make_na_block( | |||
| dtype = interleaved_dtype([blk.dtype for blk in self.blocks]) | |||
| if dtype is not None and np.issubdtype(dtype.type, np.floating): | |||
| fill_value = dtype.type(fill_value) | |||
| if dtype is not None and np.issubdtype(dtype.type, np.datetime64): | |||
| fill_value = np.datetime64("NaT") | |||
There was a problem hiding this comment.
can you also pass an appropriate unit to np.datetime64
There was a problem hiding this comment.
Thanks for the feedback! I was wondering what do you mean by unit?
| tm.assert_frame_equal(result, expected) | ||
|
|
||
| @pytest.mark.xfail(reason="NaT op NaT results in datetime instead of timedelta") | ||
| def test_arithmetic_timestamp_timedelta(self): |
There was a problem hiding this comment.
IIUC these tests are mainly about the alignment behavior, so they belong in something like tests.frame.test_arithmetic
There was a problem hiding this comment.
The tests are currently in pandas/tests/frame/test_arithmetic.py. Should they be moved somewhere else?
| @@ -1147,6 +1147,33 @@ def test_arithmetic_midx_cols_different_dtypes_different_order(self): | |||
| expected = DataFrame([[-1, 1], [-1, 1]], columns=midx) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| @pytest.mark.xfail(reason="NaT op NaT results in datetime instead of timedelta") | |||
There was a problem hiding this comment.
@jbrockmendel in this test, the comparison fails because the result dtype value of NaT is datetime64 and expected dtype value of NaT is Timedelta. I would expect NaT - NaT to result in Timedelta. Is this behavior expected?
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.