Skip to content

Backport PR #59818 on branch 2.2.x (BUG: Remove np._get_promotion_state usage) #59821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2024
Merged

Backport PR #59818 on branch 2.2.x (BUG: Remove np._get_promotion_state usage) #59821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pandas/tests/series/indexing/test_setitem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
datetime,
)
from decimal import Decimal
import os

import numpy as np
import pytest

from pandas.compat import WASM
from pandas.compat.numpy import np_version_gte1p24
from pandas.errors import IndexingError

Expand Down Expand Up @@ -1443,7 +1445,11 @@ def obj(self):
marks=pytest.mark.xfail(
(
not np_version_gte1p24
or (np_version_gte1p24 and np._get_promotion_state() != "weak")
or (
np_version_gte1p24
and os.environ.get("NPY_PROMOTION_STATE", "weak") != "weak"
)
or WASM
),
reason="np.float32(1.1) ends up as 1.100000023841858, so "
"np_can_hold_element raises and we cast to float64",
Expand Down
Loading