Fix issue #47101 #59766
Open
Fix issue #47101 #59766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix issue pandas-dev#47101 Bisecting two years ago ( pandas-dev#47101 (comment) ) shows this regression was introduced in b2d54d9 in 2021. Somehow this hasn't been patched since then. PR pandas-dev#48313 was supposed to address this, but the PR was closed and never merged and the bug has persisted. * Add a test as per PR guidelines * Fix typo * Resolve inconsistent namespace as per PR test https://results.pre-commit.ci/run/github/858127/1723498369.6V12SWx7T-WpLZDAXXkz0Q This web UI commit will still fail, as the E501 line-too-long check will fail until the next commit * Resolve E501 linting errors https://results.pre-commit.ci/run/github/858127/1723498369.6V12SWx7T-WpLZDAXXkz0Q * Fix test TypeErrors np.equal([1,2,3], "") fails * Quote style for Ruff * typing and remove code backtick possibly incorrectly triggering ruff formatter * mpy supression for caught error * trailing space
…ring_array (pandas-dev#59756) (#2) * BUG (string dtype): fix inplace mutation with copy=False in ensure_string_array * update Co-authored-by: Joris Van den Bossche <[email protected]>
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
It's still a valid PR
- via Pixel 8pro (pardon insane autocorrects) -
…On Wed, Oct 9, 2024, 17:07 github-actions[bot] ***@***.***> wrote:
This pull request is stale because it has been open for thirty days with
no activity. Please update
<https://pandas.pydata.org/pandas-docs/stable/development/contributing.html#updating-your-pull-request>
and respond to this comment if you're still interested in working on this.
—
Reply to this email directly, view it on GitHub
<#59766 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABIQMJA2DVTSMYOLTW6GK3Z2XALZAVCNFSM6AAAAABN5F37KCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBTGY2DMNZXGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reapplies PR #59492
See #59492 (comment)
Bisecting two years ago ( #47101 (comment) ) shows this regression was introduced in b2d54d9 in 2021. Somehow this hasn't been patched since then.
PR #48313 was supposed to address this, but the PR was closed and never merged and the bug has persisted.
Patch takes two tracks -- it first replaces the
arr == xwithnp.equals()which will handle broadcasting in most cases by itself. For the remainder of cases, an explicit type check is done to return an array for the mask.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Has a KNOWN test failure of
but I honestly have no clue what's failing in that. Some inscrutable and poorly reported style problem?