increase verbosity #59649
Closed
increase verbosity #59649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
increase verbosity of error message by including the type causing the error in the error message
|
Is this PR associated with an issue? |
|
@mroeschke I've opened one now #59659 |
mroeschke
reviewed
Aug 30, 2024
| @@ -252,7 +252,7 @@ def _validate(data): | |||
| inferred_dtype = lib.infer_dtype(values, skipna=True) | |||
|
|
|||
| if inferred_dtype not in allowed_types: | |||
| raise AttributeError("Can only use .str accessor with string values!") | |||
| raise AttributeError(f"Can only use .str accessor with string values! Inferred dType: {inferred_dtype}") | |||
There was a problem hiding this comment.
Suggested change
| raise AttributeError(f"Can only use .str accessor with string values! Inferred dType: {inferred_dtype}") | |
| raise AttributeError(f"Can only use .str accessor with string values, not {inferred_dtype}.") |
|
can I re-open a new PR regarding this? seems like this PR has become stale |
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
increase verbosity of error message by including the type causing the error in the error message
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature. -> minor change