-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Clarified documentation for MultiIndexes #5964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Clarified documentation for MultiIndexes #5964
Conversation
One of the Travis CI builds seems to have failed due to a temporary network error: Is there some way to rerun the job that failed? |
Regarding Travis, I don't think this is really a problem as this PR only touches documentation and no code, but if you want to retrigger Travis, you can reset the last commit and push --force again:
|
But for lower levels, be aware that the MultiIndex is fundamentally a | ||
one-dimensional object: when slicing, you are specifying a start and an end | ||
point on a 1D array, rather than selecting a rectangular block of n-dimensional | ||
space as done in numpy or MATLAB array slicing: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the "rather than selecting a rectangular block of n-dimensional space as done in numpy or MATLAB array slicing" not super clear.
The thing you want to say, is it that "slicing the (lower) levels seperately is not possible"?
@felixlawrence Thanks for the PR! This is indeed an area that can use some clarification. I just made some small comments. |
@felixlawrence their is a button on the rhs of the screen for that rebuilt to rerun / cancel a build as well (relatively new feature on github) |
@felixlawrence +1 for the examples. Maybe still another suggestion: you could add a "See also" to each docstring referring to the other. Something like this:
And lastly, before merging, could you squash to the commits to one? See https://github.com/pydata/pandas/wiki/Using-Git#fetch-and-then-rebase-interactively-to-squash-reword-fix-otherwise-change-some-commits |
Add examples and rewrite an awkwardly-written bit Cross-reference MultiIndex constructors
I added the cross-references, committed, and squashed the commits as per the link, but couldn't push the commit up to this branch (presumably because I had squashed commits locally that are present in this remote branch). What should I do? |
@felixlawrence you have to force push. |
@felixlawrence It seems it's OK now (the commit looks fine, and the travis failing is due to another issue (missing six)), so merging. Thanks for the contribution! |
DOC: Clarified documentation for MultiIndexes
Clarify some quirks regarding slicing on MultiIndexes