REF (string): avoid copy in StringArray factorize #59551
Merged
+34
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Refactor
jbrockmendel
changed the title
mroeschke
approved these changes
Aug 22, 2024
|
Thanks @jbrockmendel |
matiaslindgren
pushed a commit
to matiaslindgren/pandas
that referenced
this pull request
Aug 25, 2024
* REF: avoid copy in StringArray factorize * mypy fixup * un-xfail
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Oct 10, 2024
* REF: avoid copy in StringArray factorize * mypy fixup * un-xfail
jorisvandenbossche
pushed a commit
that referenced
this pull request
Oct 10, 2024
* REF: avoid copy in StringArray factorize * mypy fixup * un-xfail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Initial motivation was to avoid the ugly overrides of _from_backing_data. Turns out that override is needed for NumpyExtensionArray bc of the masking currently done in NumpyEA._values_for_factorize. That masking is in turn necessary because of incorrect comparisons in the hashtable cython code.
update 2024-08022 adding "(string)" to the title since this now fixes an infer-string xfail.