Skip to content

REF (string): remove _str_na_value #59515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke
Copy link
Member

mypy.....................................................................Failed
- hook id: mypy
- duration: 79.93s
- exit code: 1

pandas/core/strings/object_array.py:67: error: "ObjectStringArrayMixin" has no attribute "dtype"  [attr-defined]
pandas/core/strings/object_array.py:273: error: "ObjectStringArrayMixin" has no attribute "dtype"  [attr-defined]
pandas/core/strings/object_array.py:467: error: "ObjectStringArrayMixin" has no attribute "dtype"  [attr-defined]
Found 3 errors in 1 file (checked 1441 source files)

@mroeschke mroeschke added Refactor Internal refactoring of code Strings String extension data type and string data labels Aug 14, 2024
@mroeschke mroeschke added this to the 3.0 milestone Aug 15, 2024
@mroeschke mroeschke merged commit 66e465e into pandas-dev:main Aug 15, 2024
47 checks passed
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-str_na_value branch August 15, 2024 20:34
@jorisvandenbossche jorisvandenbossche modified the milestones: 3.0, 2.3 Aug 20, 2024
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 22, 2024
* REF (string): remove _str_na_value

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 22, 2024
* REF (string): remove _str_na_value

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 22, 2024
* REF (string): remove _str_na_value

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 22, 2024
* REF (string): remove _str_na_value

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 27, 2024
* REF (string): remove _str_na_value

* mypy fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Sep 20, 2024
* REF (string): remove _str_na_value

* mypy fixup
jorisvandenbossche pushed a commit to WillAyd/pandas that referenced this pull request Oct 2, 2024
* REF (string): remove _str_na_value

* mypy fixup
jorisvandenbossche pushed a commit to WillAyd/pandas that referenced this pull request Oct 2, 2024
* REF (string): remove _str_na_value

* mypy fixup
jorisvandenbossche pushed a commit to WillAyd/pandas that referenced this pull request Oct 3, 2024
* REF (string): remove _str_na_value

* mypy fixup
jorisvandenbossche pushed a commit to WillAyd/pandas that referenced this pull request Oct 7, 2024
* REF (string): remove _str_na_value

* mypy fixup
jorisvandenbossche pushed a commit that referenced this pull request Oct 9, 2024
* REF (string): remove _str_na_value

* mypy fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Refactor Internal refactoring of code Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants