Skip to content

TST (string dtype): fix IO dtype_backend tests for storage of str dtype of columns' Index #59509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2024
+21 −11
Merged

TST (string dtype): fix IO dtype_backend tests for storage of str dtype of columns' Index #59509

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d29de90
TST (string dtype): fix failure in csv test_dtype_backend_string test
jorisvandenbossche Aug 14, 2024
57b7d51
ignore storage of Index str dtype
jorisvandenbossche Aug 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pandas/tests/io/parser/dtypes/test_dtypes_basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,12 +470,12 @@ def test_dtype_backend_string(all_parsers, string_storage):
"""
result = parser.read_csv(StringIO(data), dtype_backend="numpy_nullable")

expected = DataFrame(
{
"a": pd.array(["a", "b"], dtype=pd.StringDtype(string_storage)),
"b": pd.array(["x", pd.NA], dtype=pd.StringDtype(string_storage)),
}
)
expected = DataFrame(
{
"a": pd.array(["a", "b"], dtype=pd.StringDtype(string_storage)),
"b": pd.array(["x", pd.NA], dtype=pd.StringDtype(string_storage)),
},
)
Comment on lines +473 to +478
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What this is changing is that the expected result is also created in the with pd.option_context("mode.string_storage", string_storage): context. What this actually changes is that when future.infer_string is enabled, that affects the storage used by the Index object with str dtype used for the columns of the resulting dataframe.

tm.assert_frame_equal(result, expected)


Expand Down
Loading