REF: remove unused variable and checks #59463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Aug 9, 2024
| @@ -158,15 +158,8 @@ def f(self): | |||
| # these return a boolean by-definition | |||
| return result | |||
|
|
|||
| if field in self._object_ops: | |||
There was a problem hiding this comment.
Can _object_ops be in-lined in _datetimelike_ops now since this usage is removed?
There was a problem hiding this comment.
I think so. Will update.
|
@jbrockmendel should this be backported along with your previous PRs touching |
|
This doesnt need backport, no. |
jbrockmendel
force-pushed
the
ref-convert
branch
from
bea0f8c to
1f7305f
Compare
mroeschke
approved these changes
Aug 13, 2024
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.