Skip to content

Use bash as default shell in Dockerfile #59456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

serl
Copy link
Contributor

@serl serl commented Aug 9, 2024

GitPod's VSCode in browser (and probably others?) defaults to use $SHELL in integrated terminal, which is sh.
This change is just confort to have it open bash without having to change the settings or open the right one manually.

Note that the .devcontainer setting should not be necessary anymore, as the algorithm to chose the right shell should be the same for GitPod and VSCode remote.

From the relevant VSCode doc:

The default terminal profile shell defaults to $SHELL on Linux and macOS and PowerShell on Windows. VS Code will automatically detect most standard shells that can then be configured as the default.

EDIT
Added a couple of bonus points:

  • --install-hooks in pre-commit. This will configure everything immediately. Otherwise, the first commit will be very slow (pre-commit creates the environments on-demand, this will force the creation at the first start)
  • bash-completion. So to everything (git completion works out of the box, for example)

@WillAyd WillAyd merged commit 603f105 into pandas-dev:main Aug 9, 2024
45 checks passed
@WillAyd
Copy link
Member

WillAyd commented Aug 9, 2024

Thanks @serl these are nice changes. I don't think very many core developers are using this at the moment, so if you run into issues feel free to keep pushing up PRs. Would be great to improve

@serl serl deleted the dockerfile-default-shell-bash branch August 10, 2024 08:26
@serl
Copy link
Contributor Author

serl commented Aug 10, 2024

Hello @WillAyd, thanks for the fast reply!

Yes I think there'll be more to do (looking at #59459). I'm not really familiar with the project yet, so if you have advices on that issue, I'd be grateful (otherwise I'll crawl my way in 🦝)

@WillAyd
Copy link
Member

WillAyd commented Aug 10, 2024

Thanks @serl . I also do not use Gitpod so am not up to speed on what may or may not be working with it. If you use it and run into problems, I would just continue to create an issue for the buggy behavior (or find one, if it already exists) and can get directed feedback from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants