TST (string dtype): replace string_storage fixture with explicit storage/na_value keyword arguments for dtype creation #59375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age/na_value keyword arguments for dtype creation
jorisvandenbossche
added
Testing
mroeschke
approved these changes
Jul 31, 2024
|
Thanks @jorisvandenbossche |
jorisvandenbossche
deleted the
string-dtype-tests-fixtures-string_storage
branch
41 tasks
WillAyd
pushed a commit
that referenced
this pull request
Aug 13, 2024
…age/na_value keyword arguments for dtype creation (#59375)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 14, 2024
…age/na_value keyword arguments for dtype creation (pandas-dev#59375)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 15, 2024
…age/na_value keyword arguments for dtype creation (pandas-dev#59375)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 15, 2024
…age/na_value keyword arguments for dtype creation (pandas-dev#59375)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 15, 2024
…age/na_value keyword arguments for dtype creation (pandas-dev#59375)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 21, 2024
…age/na_value keyword arguments for dtype creation (pandas-dev#59375)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
…age/na_value keyword arguments for dtype creation (pandas-dev#59375)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
…age/na_value keyword arguments for dtype creation (pandas-dev#59375)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 27, 2024
…age/na_value keyword arguments for dtype creation (pandas-dev#59375)
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Sep 20, 2024
…age/na_value keyword arguments for dtype creation (pandas-dev#59375)
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 2, 2024
…age/na_value keyword arguments for dtype creation (pandas-dev#59375)
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 2, 2024
…age/na_value keyword arguments for dtype creation (pandas-dev#59375)
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 3, 2024
…age/na_value keyword arguments for dtype creation (pandas-dev#59375)
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 7, 2024
…age/na_value keyword arguments for dtype creation (pandas-dev#59375)
jorisvandenbossche
added a commit
that referenced
this pull request
Oct 9, 2024
…age/na_value keyword arguments for dtype creation (#59375)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
string_storagefixture is currently still parametrized as "python", "pyarrow" and "pyarrow_numpy". In light of the PDEP-14 work, we need to get rid of the "pyarrow_numpy" option (since this is replaced bystorage="pyarrrow", na_value=np.nan).This PR introduces a new fixture to replace the current one for a subset of its use cases, where we currently use it to create the different variants of the string dtype.
(we might also want to have a direct top-level fixture for those string dtype, but: 1) for those tests, the fixture should be named
dtypeand so easier to keep that defined within the file, 2) we already have a top-levelany_string_dtypefixture, but that also includesobjectdtype)xref #54792