Skip to content

fix: show correct error message when invalid period alias is passed to to_timestamp #59373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix: show correct error message when invalid period alias is passed to to_timestamp #59373

merged 1 commit into from
Aug 1, 2024

Conversation

MarcoGorelli
Copy link
Member

addresses #58974 (comment)

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@MarcoGorelli MarcoGorelli marked this pull request as ready for review July 31, 2024 16:42
@MarcoGorelli MarcoGorelli added the Frequency DateOffsets label Jul 31, 2024
@MarcoGorelli MarcoGorelli requested a review from natmokval July 31, 2024 16:43
@mroeschke mroeschke added the Error Reporting Incorrect or improved errors from pandas label Jul 31, 2024
@natmokval
Copy link
Contributor

thanks @MarcoGorelli for fixing this. Looks good to me.

@mroeschke mroeschke added this to the 3.0 milestone Aug 1, 2024
@mroeschke mroeschke merged commit 7ee1091 into pandas-dev:main Aug 1, 2024
46 of 53 checks passed
@mroeschke
Copy link
Member

Thanks @MarcoGorelli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@natmokval natmokval Awaiting requested review from natmokval

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas Frequency DateOffsets
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcoGorelli @natmokval @mroeschke