TST (string dtype): follow-up on GH-59329 fixing new xfails #59352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Testing
Comment on lines
+583
to
+586
| elif isinstance(left, StringDtype): | ||
| # TODO(infer_string) this special case could be avoided if we have | ||
| # a more informative repr https://github.com/pandas-dev/pandas/issues/59342 | ||
| left = f"StringDtype(storage={left.storage}, na_value={left.na_value})" |
There was a problem hiding this comment.
See #58451 (comment) for some discussion, but in short I am adding this for now because right now you can get test failures (like the ones that this PR is silencing with xfails) that have a very hard assert message like:
AssertionError: Attributes of DataFrame.iloc[:, 0] (column name="col1") are different
Attribute "dtype" are different
[left]: string[pyarrow]
[right]: string[pyarrow]
which is not very helpful ...
The reason for that is because I did not bake the pd.NA vs np.nan information in the string alias / representation.
We need to resolve that issue more in general (see the linked issue in the comment above), but short term this ensures that at least for developing and running tests, we can distinguish easily between the different dtypes.
|
The build (for future strings) is green again. I think it would be good to merge this rather quickly given it's fixing failures on main (will do in a few hours if no-one beats me to it). |
mroeschke
approved these changes
Jul 30, 2024
|
Thanks @jorisvandenbossche |
41 tasks
WillAyd
pushed a commit
that referenced
this pull request
Aug 13, 2024
* TST (string dtype): follow-up on GH-59329 fixing new xfails * add missing strict
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 14, 2024
…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 15, 2024
…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 15, 2024
…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 15, 2024
…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 21, 2024
…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 22, 2024
…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Aug 27, 2024
…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict
WillAyd
pushed a commit
to WillAyd/pandas
that referenced
this pull request
Sep 20, 2024
…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 2, 2024
…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 2, 2024
…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 3, 2024
…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict
jorisvandenbossche
added a commit
to WillAyd/pandas
that referenced
this pull request
Oct 7, 2024
…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict
jorisvandenbossche
added a commit
that referenced
this pull request
Oct 9, 2024
* TST (string dtype): follow-up on GH-59329 fixing new xfails * add missing strict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #59329, which caused some failures on main after being merged (see #59329 (comment))
xref #54792