Skip to content

TST: Remove unnecessary test_boolean_types.xlsx #59348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

mroeschke
Copy link
Member

When this test is run, the file is overridden which could be accidentally committed. Having an actual excel file for this test is not necessary since this is just checking type casting

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite IO Excel read_excel, to_excel labels Jul 29, 2024
@mroeschke mroeschke added this to the 3.0 milestone Jul 29, 2024
@mroeschke
Copy link
Member Author

Since tests are passing going to merge

@mroeschke mroeschke merged commit f4c454a into pandas-dev:main Jul 29, 2024
44 of 50 checks passed
@mroeschke mroeschke deleted the test/excel branch July 29, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Excel read_excel, to_excel Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant