Skip to content

CI/DOC: Fix CI failure for Status: Draft PDEPs and don't show them on the roadmap webpage #59254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2024
Merged

CI/DOC: Fix CI failure for Status: Draft PDEPs and don't show them on the roadmap webpage #59254

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfbe222
CI: fix CI failure for PDEP with status: Draft
Aloqeely Apr 27, 2024
d12d9e5
Exclude draft PDEPs
Aloqeely Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion web/pandas_web.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,7 @@ def roadmap_pdeps(context):
PDEP's in different status from the directory tree and GitHub.
"""
KNOWN_STATUS = {
"Draft",
"Under discussion",
"Accepted",
"Implemented",
Expand Down Expand Up @@ -319,7 +320,7 @@ def roadmap_pdeps(context):
github_repo_url = context["main"]["github_repo_url"]
resp = requests.get(
"https://api.github.com/search/issues?"
f"q=is:pr is:open label:PDEP repo:{github_repo_url}",
f"q=is:pr is:open label:PDEP draft:false repo:{github_repo_url}",
headers=GITHUB_API_HEADERS,
timeout=5,
)
Expand Down