BUG: Fix read_csv index dtype override #59219
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xouyang1
changed the title
|
hey, thanks for the ping and the PR - I'm not really familiar with this part of the codebase. I can take a look but I'm afraid there are other priorities at the moment |
xouyang1
commented
Jul 20, 2024
| if isinstance(data, np.ndarray) and isinstance(conv_data, range) | ||
| else None | ||
| ) | ||
| return Index(conv_data, dtype=dtype, name=names) |
There was a problem hiding this comment.
#59077 (comment)
I think this is the best place to add in the explicit dtype after the possible conversion to python native range type.
|
@mroeschke Hi Matthew, can you help take a look at my pr for this? |
|
Sorry I just merged #59316 which overlaps with your fix here. Thanks for the contribution but going to close now that the issue is fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type annotations to new arguments/methods/functions.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.