BUG: Fix difference functionality for Period Indexes #59148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
approved these changes
Jul 26, 2024
| def _difference(self, other, sort=None) -> PeriodIndex: | ||
| if isinstance(other, Index) and other.inferred_type == "string": | ||
| try: | ||
| other = other.astype(self.dtype) |
There was a problem hiding this comment.
I don’t think we do this type of casting in general. In fact, I’d expect the private _difference to only be reached with matching dtypes
| tm.assert_index_equal(idx_diff, expected) | ||
|
|
||
| idx_diff = other.difference(index, sort) | ||
| expected = pd.Index([]) |
There was a problem hiding this comment.
No, the difference should be the entire ‘other’
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Index.differenceis returning too many values #58971doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.