Skip to content

BUG: dt+BDay(n) wrong if n>5, n%5==0 and dt not on offset (GH5890) #5911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 13, 2014

Conversation

dd137
Copy link
Contributor

@dd137 dd137 commented Jan 12, 2014

closes #5890

@jreback
Copy link
Contributor

jreback commented Jan 12, 2014

looks good...pls do a rebase on master and can merge it....

@dd137
Copy link
Contributor Author

dd137 commented Jan 13, 2014

Hi,
When I do "git rebase upstream/master" I get "Current branch bday-addition is up to date."
Not sure if I need to do something more/else?

@jreback
Copy link
Contributor

jreback commented Jan 13, 2014

sorry

git fetch upstrem
git rebase upstream/master

see here:

https://github.com/pydata/pandas/wiki/Using-Git

@dd137
Copy link
Contributor Author

dd137 commented Jan 13, 2014

Yeah this is what I had done before and git is saying the branch is up to date, hence I'm thinking I'm done on my side. Is that correct or do I need to do something more? Sorry for the confusion

@jreback
Copy link
Contributor

jreback commented Jan 13, 2014

it can't be automatically merged prob a conflict on release.rst

did you push it after?

git push origin mybranchname -f?

@jreback
Copy link
Contributor

jreback commented Jan 13, 2014

you can also try this

git branch mybranchname -set-upstream origin/master

it might not be looking at right tracking branch (iow you are rebaseing to your own branch)

@dd137
Copy link
Contributor Author

dd137 commented Jan 13, 2014

Ah I see thanks. I think it worked this time (I've had to solve the conflicts in release.rst)

jreback added a commit that referenced this pull request Jan 13, 2014
BUG: dt+BDay(n) wrong if n>5, n%5==0 and dt not on offset (GH5890)
@jreback jreback merged commit 9a67dbc into pandas-dev:master Jan 13, 2014
@jreback
Copy link
Contributor

jreback commented Jan 13, 2014

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dt+BDay(n) gives the wrong date if n>5, n%5==0 and dt not on offset
2 participants