DOC: Clarify interaction of read_csv nrows with other args (#59078) #59084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdavis-xyz
force-pushed
the
59078-nrow-doc
branch
from
855fd8c to
14d5576
Compare
mdavis-xyz
force-pushed
the
59078-nrow-doc
branch
from
14d5576 to
83fb858
Compare
Aloqeely
reviewed
Jun 24, 2024
pandas/io/parsers/readers.py
Outdated
Comment on lines
274
to
278
| * The header row containing column names, | ||
| * Rows before the header row, if ``header=1`` or larger, | ||
| * Fully commented rows, | ||
| * Rows skipped with ``skiprows``, | ||
| * Skipped blank lines. |
There was a problem hiding this comment.
The last 3 seem obvious to me, it might be better to remove them since the doc page of read_csv is quite long already.
There was a problem hiding this comment.
Should I just say that nrows limits the number of rows of the returned dataframe? I can't find any edge case where that is not true.
There was a problem hiding this comment.
Ok I've updated that now.
|
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.