BUG: Add type check for encoding_errors in pd.read_csv #59075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jun 24, 2024
pandas/io/parsers/readers.py
Outdated
| @@ -1413,6 +1413,13 @@ def _make_engine( | |||
| raise ValueError( | |||
| f"Unknown engine: {engine} (valid options are {mapping.keys()})" | |||
| ) | |||
|
|
|||
| errors = self.options.get("encoding_errors", "strict") | |||
| if not isinstance(errors, str) and errors is not None: | |||
There was a problem hiding this comment.
Suggested change
| if not isinstance(errors, str) and errors is not None: | |
| if not isinstance(errors, str): |
mroeschke
reviewed
Jun 24, 2024
pandas/io/parsers/readers.py
Outdated
| @@ -1413,6 +1413,13 @@ def _make_engine( | |||
| raise ValueError( | |||
| f"Unknown engine: {engine} (valid options are {mapping.keys()})" | |||
| ) | |||
|
|
|||
| errors = self.options.get("encoding_errors", "strict") | |||
There was a problem hiding this comment.
Could you move this logic into _read?
There was a problem hiding this comment.
Okay, I have moved it into _read
mroeschke
requested changes
Jun 24, 2024
mroeschke
added
Error Reporting
mroeschke
reviewed
Jun 25, 2024
mroeschke
reviewed
Jun 25, 2024
mroeschke
reviewed
Jun 25, 2024
mroeschke
reviewed
Jun 25, 2024
Co-authored-by: Matthew Roeschke <[email protected]>
Co-authored-by: Matthew Roeschke <[email protected]>
Co-authored-by: Matthew Roeschke <[email protected]>
Co-authored-by: Matthew Roeschke <[email protected]>
|
Could you add a unit test to validate the exception message? |
Ok, I added a test. |
mroeschke
reviewed
Jun 27, 2024
pandas/tests/io/test_common.py
Outdated
| @@ -590,6 +590,24 @@ def test_encoding_errors(encoding_errors, format): | |||
| tm.assert_frame_equal(df, expected) | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("encoding_errors", [0, None, "strict"]) | |||
There was a problem hiding this comment.
Don't need to test "strict" here
mroeschke
reviewed
Jun 27, 2024
mroeschke
reviewed
Jun 27, 2024
Co-authored-by: Matthew Roeschke <[email protected]>
Co-authored-by: Matthew Roeschke <[email protected]>
mroeschke
approved these changes
Jun 27, 2024
|
Thanks @Aliebc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.