-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: More doc fix for dtype_backend #59071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me when we have numpy_nullable
or pyarrow
lines in the docs, they should closely mirror each other. See requests below.
Honestly, I've lost track of the current PR, but I'll do my utmost to address all comments. If further changes are needed, I'll make them promptly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! One last line and I think we're good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @luke396! |
dtype_backend
parameter description to make them all consistent #54104, following DOC: Changeto_numeric
'sdtype_backend
default doc #59021doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.