-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
Fix insertion of None value in MultiIndex #59069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
efff668
Fix insertion of None value in MultiIndex
chaoyihu fc8e053
add whatnew entry
chaoyihu 385cb65
check for NA values using missing::isna
chaoyihu bea513e
adding test insertion of np.nan
chaoyihu 62a038c
update whatsnew entry
chaoyihu 84859a2
test case revision
chaoyihu 766d28b
Merge branch 'main' into multiindex-insert-na
mroeschke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ | |
import pandas as pd | ||
from pandas import ( | ||
DataFrame, | ||
Index, | ||
MultiIndex, | ||
Series, | ||
) | ||
|
@@ -288,6 +289,14 @@ def test_multiindex_with_na(self): | |
|
||
tm.assert_frame_equal(df, expected) | ||
|
||
def test_multiindex_insert_level_with_na(self): | ||
# GH 59003 | ||
indices = [["one"], ["a"], ["yes"]] | ||
df = DataFrame([0], index=indices).T | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you construct this without |
||
df["one", None, "yes"] = 1 | ||
expected = DataFrame([1], index=Index(["yes"])).T | ||
tm.assert_frame_equal(df["one"][None], expected) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you test this without doing a chained indexing? |
||
|
||
|
||
class TestSorted: | ||
"""everything you wanted to test about sorting""" | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick