Skip to content

Fix insertion of None value in MultiIndex #59069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 25, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v3.0.0.rst
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,7 @@ MultiIndex
^^^^^^^^^^
- :func:`DataFrame.loc` with ``axis=0`` and :class:`MultiIndex` when setting a value adds extra columns (:issue:`58116`)
- :meth:`DataFrame.melt` would not accept multiple names in ``var_name`` when the columns were a :class:`MultiIndex` (:issue:`58033`)
- :meth:`MultiIndex.insert` would not insert NA value correctly at unified location of index -1 (:issue:`59003`)
-

I/O
Expand Down
7 changes: 5 additions & 2 deletions pandas/core/indexes/multi.py
Original file line number Diff line number Diff line change
Expand Up @@ -3906,8 +3906,11 @@ def insert(self, loc: int, item) -> MultiIndex:
# have to insert into level
# must insert at end otherwise you have to recompute all the
# other codes
lev_loc = len(level)
level = level.insert(lev_loc, k)
if isna(k): # GH 59003
lev_loc = -1
else:
lev_loc = len(level)
level = level.insert(lev_loc, k)
else:
lev_loc = level.get_loc(k)

Expand Down
12 changes: 12 additions & 0 deletions pandas/tests/test_multilevel.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import pandas as pd
from pandas import (
DataFrame,
Index,
MultiIndex,
Series,
)
Expand Down Expand Up @@ -288,6 +289,17 @@ def test_multiindex_with_na(self):

tm.assert_frame_equal(df, expected)

def test_multiindex_insert_level_with_na(self):
# GH 59003
indices = [["one"], ["a"], ["yes"]]
df = DataFrame([0], index=indices).T
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you construct this without .T?

df["one", None, "yes"] = 1
expected = DataFrame([1], index=Index(["yes"])).T
tm.assert_frame_equal(df["one"][None], expected)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you test this without doing a chained indexing?

df["one", np.nan, "yes"] = 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use pytest.mark.parametrize with np.nan and None

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I tried to stay close to the reproducible code example in the linked issue, but it's really not necessary. Now the test case looks more concise and to the point. Thanks for the suggestions.

expected = DataFrame([1], index=Index(["yes"])).T
tm.assert_frame_equal(df["one"][np.nan], expected)


class TestSorted:
"""everything you wanted to test about sorting"""
Expand Down
Loading