Skip to content

CLN: BaseGrouper #59034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 17, 2024
Merged

CLN: BaseGrouper #59034

merged 4 commits into from
Jun 17, 2024

Conversation

mroeschke
Copy link
Member

  • BaseGrouper.group_info seems wholly redundant with ids and ngroups which are also already defined properties. Removed group_info since usages don't need both components
  • BaseGrouper.shape was not used
  • DataSplitter.labels was not used

@mroeschke mroeschke requested a review from rhshadrach as a code owner June 17, 2024 17:25
rhshadrach
rhshadrach approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach
Copy link
Member

Failing builds appear unrelated.

@rhshadrach rhshadrach merged commit ee05885 into pandas-dev:main Jun 17, 2024
45 of 47 checks passed
@rhshadrach
Copy link
Member

Thanks @mroeschke

@rhshadrach rhshadrach added this to the 3.0 milestone Jun 17, 2024
@mroeschke mroeschke deleted the cln/basegrouper branch June 17, 2024 20:07
clin1234 pushed a commit to clin1234/pandas that referenced this pull request Jun 18, 2024
@mroeschke @clin1234
CLN: BaseGrouper (pandas-dev#59034)
eeb575d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Clean Groupby
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @rhshadrach