-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
PREF: Fix regression from #58984 #59025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke396
commented
Jun 17, 2024
@@ -398,11 +398,12 @@ def group_cumsum( | |||
for i in range(N): | |||
lab = labels[i] | |||
|
|||
if lab < 0: | |||
if uses_mask and lab < 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the solution for the bug fix mentioned in #58984 is the only one available, I believe some regression may be unavoidable.
On my local machine, this change seems to yield some performance gains, but perhaps they are merely an illusion.
|
mroeschke
approved these changes
Jun 17, 2024
Thanks @luke396 |
clin1234
pushed a commit
to clin1234/pandas
that referenced
this pull request
Jun 18, 2024
* check uses_mask before * backup gh * backup gh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
group_cumsum
(#58984)" #59022 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.