Skip to content

PERF: cache plotting date locators for DatetimeIndex plotting #58992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2024
+8 −4
Merged

PERF: cache plotting date locators for DatetimeIndex plotting #58992

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6dcdd83
PERF: cache plotting date locators for DatetimeIndex plotting
mroeschke Jun 12, 2024
efec20f
Type vmin, vmax
mroeschke Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pandas/plotting/_matplotlib/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,6 +556,7 @@ def _get_periods_per_ymd(freq: BaseOffset) -> tuple[int, int, int]:
return ppd, ppm, ppy


@functools.cache
def _daily_finder(vmin, vmax, freq: BaseOffset) -> np.ndarray:
# error: "BaseOffset" has no attribute "_period_dtype_code"
dtype_code = freq._period_dtype_code # type: ignore[attr-defined]
Expand Down Expand Up @@ -755,6 +756,7 @@ def _second_finder(label_interval: int) -> None:
return info


@functools.cache
def _monthly_finder(vmin, vmax, freq: BaseOffset) -> np.ndarray:
_, _, periodsperyear = _get_periods_per_ymd(freq)

Expand Down Expand Up @@ -826,6 +828,7 @@ def _monthly_finder(vmin, vmax, freq: BaseOffset) -> np.ndarray:
return info


@functools.cache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No chance of getting non-hashable inputs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think vmax/vmin are always floats. I'll type these so we have some validation

def _quarterly_finder(vmin, vmax, freq: BaseOffset) -> np.ndarray:
_, _, periodsperyear = _get_periods_per_ymd(freq)
vmin_orig = vmin
Expand Down Expand Up @@ -873,6 +876,7 @@ def _quarterly_finder(vmin, vmax, freq: BaseOffset) -> np.ndarray:
return info


@functools.cache
def _annual_finder(vmin, vmax, freq: BaseOffset) -> np.ndarray:
# Note: small difference here vs other finders in adding 1 to vmax
(vmin, vmax) = (int(vmin), int(vmax + 1))
Expand Down