-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH: Add support for reading 102-format Stata dta files #58978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, let us know and we can reopen. I don't think there should be that much objection to support this. |
I'm happy to continue working on this if you think that it might be useful, How would you like it referenced in the whatsnew file, given that there isn't currently an issue that it addresses? |
You can just reference this pull request |
Co-authored-by: Matthew Roeschke <[email protected]>
pandas/tests/io/test_stata.py
Outdated
ref = os.path.join(data_base, "stata-compat-118.dta") | ||
old = os.path.join(data_base, f"stata-compat-{version}.dta") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make these 2 datapath
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now made this change. Note that the equivalent tests for other format versions don't use datapath
for these either, but I haven't changed them to keep this pull restricted to just 102 format related changes.
Thanks @cmjcharlton |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.This would complete support for reading all historic Stata dta format versions.
I would understand if you chose not to merge this as:
Having said that, I am reasonably confident that the changes are correct, and Stata is happy to open and view the test data that I created: